Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update magic-string to fix invalid sourcemap issue #3349

Closed
wants to merge 1 commit into from

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3001

Description

This updates magic-string to fix an issue where invalid sourcemaps were created for tree-shaken code

@lukastaegert
Copy link
Member Author

Seems that npm audit does not like packages directly installed from Github. So this will need to wait for the proper magic-string release.

@lukastaegert lukastaegert deleted the update-magic-string branch January 21, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

source mappings of dropped code are emitted and conflict with retained code
1 participant