Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle deoptimizations while a node is being included. #3327

Merged
merged 2 commits into from Jan 8, 2020

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3324

Description

This fixes an issue with logical and conditional expressions that can arise when an expression that contains a variable reassignment is automatically included without a preceding hasEffects check.

The issue is quite complicated to trigger (see #3324) while the fix was in essence to switch the order of two lines.

@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #3327 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3327   +/-   ##
=======================================
  Coverage   93.18%   93.18%           
=======================================
  Files         172      172           
  Lines        6042     6042           
  Branches     1801     1801           
=======================================
  Hits         5630     5630           
  Misses        221      221           
  Partials      191      191
Impacted Files Coverage Δ
src/ast/nodes/ConditionalExpression.ts 96.15% <ø> (ø) ⬆️
src/ast/nodes/LogicalExpression.ts 98.7% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35e127c...fc0edd3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'include' of null
1 participant