Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to @rollup/plugin-json #3296

Closed
wants to merge 1 commit into from

Conversation

cprecioso
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

When you try to import a JSON file without the JSON plugin, the error message suggests to install it. It suggests to install rollup-plugin-json, while the new package name is @rollup/plugin-json. I updated the message to reflect that.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you also adjust the message in the tests?

@cprecioso cprecioso closed this Dec 22, 2019
@cprecioso cprecioso deleted the patch-1 branch December 22, 2019 12:29
@cprecioso cprecioso restored the patch-1 branch December 22, 2019 12:29
@cprecioso
Copy link
Contributor Author

Sorry, I removed the branch inadvertently, I am opening a new PR. (#3297)

@cprecioso cprecioso changed the title Update reference to @rollup/plugin-json in error message Update references to @rollup/plugin-json Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants