Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add syntheticNamedExports #3295
Feat: add syntheticNamedExports #3295
Changes from 11 commits
8f12bb6
90a2c3b
96c90e2
91527b7
71fca45
95ab919
7481a84
f4aa765
0bf2edb
7ccc7b4
5d21b17
1202985
7f3e896
f01ed57
d0edd56
b4d7a17
fef1cd9
7d44c8d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check should be superfluous as
this.getDefaultExport
throws when it cannot find an export. Therefore, the checkif (syntheticExport)
below is also unneeded and this can be simplified. Furthermore, the test for!this.exports[name]
should always be true as otherwise, we would not get here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor thing: Maybe call this a ...Variable so that it fits the names of the other variable types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!