New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken Windows CLI tests #3249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3249 +/- ##
==========================================
+ Coverage 91.31% 92.74% +1.42%
==========================================
Files 170 170
Lines 5930 5925 -5
Branches 1797 1793 -4
==========================================
+ Hits 5415 5495 +80
+ Misses 310 224 -86
- Partials 205 206 +1
Continue to review full report at Codecov.
|
lukastaegert
force-pushed
the
fix-windows-tests
branch
from
November 21, 2019 06:56
7926000
to
821888a
Compare
lukastaegert
force-pushed
the
fix-windows-tests
branch
from
November 21, 2019 12:02
d892f0a
to
f720a40
Compare
lukastaegert
force-pushed
the
fix-windows-tests
branch
2 times, most recently
from
November 22, 2019 06:38
5378bbb
to
08aca10
Compare
lukastaegert
force-pushed
the
fix-windows-tests
branch
from
November 22, 2019 06:41
08aca10
to
902bfe1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
As the Windows pipeline does not run for PRs from forks, some Windows CLI tests are now broken on master. This will fix those tests by introducing a helper that automatically strips escape sequences from the output before matching strings. Also, this will refine the batched warning handler and improve coverage.
Furthermore, this will change CLI warnings with two respects:
cc @tjenkinson