Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that types packages have star version ranges #3143

Merged
merged 1 commit into from Oct 5, 2019

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This fixes a regression where the star version range of the node types were replaced with a specific type. Also adds a test so that this will no longer happen.

@codecov
Copy link

codecov bot commented Oct 5, 2019

Codecov Report

Merging #3143 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3143   +/-   ##
=======================================
  Coverage   89.32%   89.32%           
=======================================
  Files         165      165           
  Lines        5734     5734           
  Branches     1739     1739           
=======================================
  Hits         5122     5122           
  Misses        379      379           
  Partials      233      233

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e51dfb...9fb1e0f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant