Use asterisk for @types/* dependencies #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could we use asterisk instead of fixed version for `@types/node` and possible other `@types/*` dependencies? This is how [DefinitelyTyped](https://github.com/DefinitelyTyped/DefinitelyTyped) publish their packages with dependencies to other typings (for example see [`@types/react/package.json`](https://unpkg.com/browse/@types/react/package.json)). It allows users to instal a single version of package with necessary typings. I believe that it may reduce the size of `node_modules` folder.
lukastaegert
approved these changes
Sep 26, 2019
Codecov Report
@@ Coverage Diff @@
## master #3131 +/- ##
=======================================
Coverage 89.32% 89.32%
=======================================
Files 165 165
Lines 5732 5732
Branches 1741 1741
=======================================
Hits 5120 5120
Misses 379 379
Partials 233 233Continue to review full report at Codecov.
|
|
@lukastaegert seems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Could we use asterisk instead of fixed version for
@types/nodeand possible other@types/*dependencies?This is how DefinitelyTyped publish their packages with dependencies to other typings (for example see
@types/react/package.json). It allows users to instal a single version of package with necessary typings.I believe that it may reduce the size of
node_modulesfolder.