Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate sourcemaps but omit the comment #3120

Merged
merged 5 commits into from Sep 27, 2019

Conversation

rohitmohan96
Copy link
Contributor

Signed-off-by: Rohit Mohan rohitmohan96@gmail.com

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #2743

Description

This adds support for sourcemap: hidden option to generate sourcemaps but omit the comment at the end of the file.

Signed-off-by: Rohit Mohan <rohitmohan96@gmail.com>
Signed-off-by: Rohit Mohan <rohitmohan96@gmail.com>
Signed-off-by: Rohit Mohan <rohitmohan96@gmail.com>
@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #3120 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3120      +/-   ##
==========================================
+ Coverage   89.31%   89.31%   +<.01%     
==========================================
  Files         165      165              
  Lines        5727     5728       +1     
  Branches     1737     1738       +1     
==========================================
+ Hits         5115     5116       +1     
  Misses        379      379              
  Partials      233      233
Impacted Files Coverage Δ
src/rollup/index.ts 93.84% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8335db...a31161e. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate sourcemaps but omit the comment
2 participants