Properly reflect dependency file names in hash #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3083 +/- ##
=======================================
Coverage 88.95% 88.95%
=======================================
Files 165 165
Lines 5721 5721
Branches 1741 1742 +1
=======================================
Hits 5089 5089
Misses 385 385
Partials 247 247
Continue to review full report at Codecov.
|
lukastaegert
force-pushed
the
gh-3060-consider-file-name-in-hash
branch
from
25e4e62
to
ee047d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #3060
Description
This PR makes sure that changes in the naming pattern or otherwise the name of a dependent chunk are properly reflected in the hash of a chunk. This is done by including the actually rendered chunk file name in the hash just with the
[hash]placeholder not replaced.