New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watch files onbuild, even if build fails #3081
Merged
Merged
Commits on Aug 24, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 5679d0a - Browse repository at this point
Copy the full SHA 5679d0aView commit details
Commits on Aug 25, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 7c003ac - Browse repository at this point
Copy the full SHA 7c003acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2162dc7 - Browse repository at this point
Copy the full SHA 2162dc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a81204e - Browse repository at this point
Copy the full SHA a81204eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3634fd - Browse repository at this point
Copy the full SHA d3634fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for e825a44 - Browse repository at this point
Copy the full SHA e825a44View commit details
Commits on Aug 26, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 830e16b - Browse repository at this point
Copy the full SHA 830e16bView commit details -
Configuration menu - View commit details
-
Copy full SHA for edb85c2 - Browse repository at this point
Copy the full SHA edb85c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for dce2d78 - Browse repository at this point
Copy the full SHA dce2d78View commit details -
Configuration menu - View commit details
-
Copy full SHA for d61f5f4 - Browse repository at this point
Copy the full SHA d61f5f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d711ecf - Browse repository at this point
Copy the full SHA d711ecfView commit details
Commits on Aug 28, 2019
-
* Do not add files to Graph.watchFiles after all files have been loaded but immediately when starting to load them so that the same watchFile logic can be used for successful and unsuccessful builds (and files added by plugins are not ignored on errors) * Do not unwatch files that have been removed if an error occurred but only when a build has succeeded * Do not re-watch files of the previous build when an error occurred as those are still being watched; just additionally watch any files attached to the error * Make sure that watching a file automatically adds it to the list of "watched" files and only reset this list when clearing unneeded files * Remove logic to filter for absolute ids for now to restore the old behaviour * Replace some .forEach with for loops for slightly improved performance
Configuration menu - View commit details
-
Copy full SHA for 0cad1b9 - Browse repository at this point
Copy the full SHA 0cad1b9View commit details -
Add watchFiles to errors not only when an explicit file position is
given but for any error that occurs during the build phase when there are already some watchFiles
Configuration menu - View commit details
-
Copy full SHA for 20a7944 - Browse repository at this point
Copy the full SHA 20a7944View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a242d2 - Browse repository at this point
Copy the full SHA 5a242d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96c8975 - Browse repository at this point
Copy the full SHA 96c8975View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d6cd53 - Browse repository at this point
Copy the full SHA 4d6cd53View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec973d1 - Browse repository at this point
Copy the full SHA ec973d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2e0a27 - Browse repository at this point
Copy the full SHA e2e0a27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c70e73 - Browse repository at this point
Copy the full SHA 3c70e73View commit details
Commits on Aug 29, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 64180e9 - Browse repository at this point
Copy the full SHA 64180e9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.