Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to acorn 7 #3061

Merged
merged 2 commits into from Aug 16, 2019
Merged

Update to acorn 7 #3061

merged 2 commits into from Aug 16, 2019

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This will update to the next major acorn version. Breaking change on acorn side is that Import has been replaced by ImportExpression with different semantics, which requires the dedicated PR.

@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #3061 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3061      +/-   ##
==========================================
+ Coverage   88.73%   88.75%   +0.02%     
==========================================
  Files         165      165              
  Lines        5734     5737       +3     
  Branches     1748     1748              
==========================================
+ Hits         5088     5092       +4     
  Misses        388      388              
+ Partials      258      257       -1
Impacted Files Coverage Δ
src/ast/nodes/index.ts 100% <ø> (ø) ⬆️
src/ast/nodes/NodeType.ts 100% <ø> (ø) ⬆️
src/ast/nodes/MetaProperty.ts 100% <100%> (+2.04%) ⬆️
src/ast/nodes/ImportExpression.ts 100% <100%> (ø)
src/Module.ts 94.19% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0b429c...02ec943. Read the comment docs.

@lukastaegert lukastaegert marked this pull request as ready for review August 16, 2019 06:30
@lukastaegert lukastaegert merged commit 8df2bc1 into master Aug 16, 2019
@lukastaegert lukastaegert deleted the update-acorn branch August 16, 2019 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants