Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): kill appveyor with fire #3059

Closed
wants to merge 3 commits into from
Closed

Conversation

shellscape
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This PR serves to test Circle CI's and Azure Pipelines' Windows test implementations. We'll choose the winner to keep around so we can kill AppVeyor with lots of fire. The goal here is to obtain faster windows builds and tests so PRs don't get held up in CI so long.

@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #3059 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3059   +/-   ##
=======================================
  Coverage   88.73%   88.73%           
=======================================
  Files         165      165           
  Lines        5735     5735           
  Branches     1748     1748           
=======================================
  Hits         5089     5089           
  Misses        388      388           
  Partials      258      258

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d18c12b...1670abd. Read the comment docs.

@shellscape
Copy link
Contributor Author

Looks like I have the configuration right for Circle CI. Azure Pipelines is a maze of funky UX and docs, and I can't figure out how to get it to read the YAML file from this branch. Going to talk with someone at Circle about bumping our plan so we can run the Windows VM.

@lazka
Copy link

lazka commented Aug 18, 2019

Azure Pipelines is a maze of funky UX and docs

yeah

, and I can't figure out how to get it to read the YAML file from this branch.

I think it only lets you create a build pipeline once you add a yaml to master.

@shellscape
Copy link
Contributor Author

Closing in favor of #3078

@shellscape shellscape closed this Aug 26, 2019
@shellscape shellscape deleted the chore/kill-appveyor branch August 26, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants