Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: issue and pull request labels refresh #3037

Merged
merged 4 commits into from Aug 7, 2019
Merged

Conversation

shellscape
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

The included labels are proposed to replace the current set as discussed in side-channels. As requested three distinct labels for code splitting, scope hoisting, and tree shaking have also been added to this set. Once approved I'll apply them using the git-labelmaker package.

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #3037 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3037   +/-   ##
=======================================
  Coverage   88.68%   88.68%           
=======================================
  Files         165      165           
  Lines        5708     5708           
  Branches     1743     1743           
=======================================
  Hits         5062     5062           
  Misses        388      388           
  Partials      258      258

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3264900...1ea858a. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, jsut some comments and questions. Do you think it would be possible to migrate at least some of the existing labels without losing the work that went into tagging? Most important to me are the bug and enhancement labels and the three bug categories.

.github/labels.json Outdated Show resolved Hide resolved
.github/labels.json Outdated Show resolved Hide resolved
.github/labels.json Outdated Show resolved Hide resolved
@shellscape
Copy link
Contributor Author

What I'd do to avoid losing tags we already have is to manually rename existing tags to the new ones, then temporarily remove those tags in the labels.json so that they weren't overwritten, and use the git-labelmaker tool to apply the rest.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@shellscape
Copy link
Contributor Author

@lukastaegert updated the release tags section per comments

.github/labels.json Outdated Show resolved Hide resolved
@shellscape shellscape merged commit af6dd1f into master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants