Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info how to install locally #2995

Merged
merged 7 commits into from Aug 11, 2019
Merged

Add info how to install locally #2995

merged 7 commits into from Aug 11, 2019

Conversation

mesqueeb
Copy link
Contributor

Fixes #2720

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Fixes #2720

@mesqueeb mesqueeb mentioned this pull request Jul 13, 2019
4 tasks
docs/04-tutorial.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #2995 into master will decrease coverage by 0.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2995      +/-   ##
=========================================
- Coverage   88.68%   87.8%   -0.88%     
=========================================
  Files         165     166       +1     
  Lines        5708    5641      -67     
  Branches     1743    1720      -23     
=========================================
- Hits         5062    4953     -109     
- Misses        388     412      +24     
- Partials      258     276      +18
Impacted Files Coverage Δ
src/utils/renderNamePattern.ts 60% <0%> (-40%) ⬇️
src/utils/relativeId.ts 83.33% <0%> (-16.67%) ⬇️
src/utils/addons.ts 86.66% <0%> (-13.34%) ⬇️
src/ast/nodes/Import.ts 93.18% <0%> (-6.82%) ⬇️
src/utils/transform.ts 90.12% <0%> (-4.69%) ⬇️
src/utils/pluginDriver.ts 82.67% <0%> (-4.5%) ⬇️
src/ModuleLoader.ts 94.08% <0%> (-3.3%) ⬇️
src/Chunk.ts 91.18% <0%> (-1.25%) ⬇️
src/ast/variables/ExportDefaultVariable.ts 88.23% <0%> (-0.96%) ⬇️
src/ast/nodes/SequenceExpression.ts 89.28% <0%> (-0.72%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af6dd1f...9d93131. Read the comment docs.

@mesqueeb
Copy link
Contributor Author

@TrySound
I have updated the branch to reflect your feedback!
Kindly review and advise. ;)

docs/04-tutorial.md Outdated Show resolved Hide resolved
docs/04-tutorial.md Outdated Show resolved Hide resolved
docs/04-tutorial.md Outdated Show resolved Hide resolved
@mesqueeb
Copy link
Contributor Author

@lukastaegert @tivac @TrySound
I have updated the PR with npx instead of npm run

docs/04-tutorial.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install and use Rollup locally
5 participants