New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sourcemap types #2985
Merged
Merged
Sourcemap types #2985
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d074f1c
Distinguish between a ExistingRawSourceMap and ExistingDecodedSourceMap
jridgewell c329849
Start work on DecodedSourceMapOrMissing type
jridgewell ad2671e
Add decodedSourcemap helper
jridgewell 9d54e5c
Fix collapseSourcemaps types
jridgewell 5aa3542
Specify Link|Source type
jridgewell 93ee458
Handle missing map in collapseSourcemaps
jridgewell 2eeed53
Remove remaining any casts
jridgewell 9027baf
Handle single item SourceMapSegmentVector
jridgewell 417e76f
Fix tests
jridgewell 38f52ad
Fix lint issues
jridgewell 550dbee
Handle null sourcemaps meaning no change in code
jridgewell ae28f18
Handle a no-mappings sourcemap
jridgewell 4de681a
Remove sourcemap-coded declaration
jridgewell aaa0558
Undo comment changes
jridgewell f936eeb
Use sourcemap-codec's types
jridgewell 597ad00
Get rid of TODO
jridgewell 37ac3e9
Use our own SourceMapSegment tuple type
jridgewell File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import { decode } from 'sourcemap-codec'; | ||
import { ExistingDecodedSourceMap, ExistingRawSourceMap, SourceMapInput } from '../rollup/types'; | ||
|
||
type Input = SourceMapInput | ExistingDecodedSourceMap | undefined; | ||
|
||
export function decodedSourcemap(map: Input): ExistingDecodedSourceMap | null { | ||
if (!map) return null; | ||
|
||
if (typeof map === 'string') { | ||
map = JSON.parse(map) as ExistingRawSourceMap; | ||
} | ||
if (map.mappings === '') { | ||
return { | ||
mappings: [], | ||
names: [], | ||
sources: [], | ||
version: 3 | ||
}; | ||
} | ||
|
||
let mappings; | ||
if (typeof map.mappings === 'string') { | ||
mappings = decode(map.mappings); | ||
} else { | ||
mappings = map.mappings; | ||
} | ||
|
||
return { ...(map as ExistingRawSourceMap | ExistingDecodedSourceMap), mappings }; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍