Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of alternate screen and simplify screen clearing #2942

Merged
merged 1 commit into from Jun 16, 2019

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no (unfortunately this is somewhat hard to test properly, suggestions welcome)

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #2252

Description

This will change Rollup to no longer use an alternate screen buffer which was causing issues as on most terminals, scrolling seems to be deactivated for alternate buffers. Also we go rid of the ansi-escapes dependency and some code could be simplified.

Would be nice if someone could check if this works as expected e.g. on Windows systems.

@timdavish
Copy link

Thanks for this! I was able to test real quick and it works great.

Unfortunately I can't help test on Windows but I'm using iTerm2/zsh.

@timdavish
Copy link

#2820 is possibly related as well

@lukastaegert
Copy link
Member Author

I was thinking about #2820 but, without having tested it, the issue sounds somewhat different. We are still clearing the screen, albeit only the visible portion of it, so it might well be that the Sirv infos are still swallowed. However I also think this should be addressed on Svelte side, either by emitting the output in a Rollup hook or setting clearScreen to false.

@lukastaegert
Copy link
Member Author

Ah what the hell, let's release it and see if anyone complains.

@lukastaegert lukastaegert merged commit 7d1bd82 into master Jun 16, 2019
@lukastaegert lukastaegert deleted the gh-2252-do-not-use-alternate-screen branch June 16, 2019 04:58
@atompkins
Copy link

Sorry for delay. if I have understood correctly new behaviour should still appear to clear the screen on build but allow scrolling back.
Screen is not clearing in integrated powershell terminal in vscode.
not a big deal for me, scrolling back is more important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using rollup --watch, I can't scroll up
3 participants