Do not produce undefined reexports when reexporting from entry points and refactor chunk linking #2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…first letter for shortened exports if possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #2877
Description
Previously, chunk linking was a slightly convoluted process where it was not always clear where an import of one chunk would become an export of another. This caused issues as in #2877. This PR fixes this by creating a clear step where all internal and external chunk imports and exports are generated together and separates the phase where facade chunks are created.
As a slight change, this PR will change the logic when imports are shortened to attempt to use the first letter of the import if it is still available. This should produce nicer code for pre-minified sources.