Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deconflict global variables used inside format-specific code #2880

Merged
merged 6 commits into from May 31, 2019
Merged

Deconflict global variables used inside format-specific code #2880

merged 6 commits into from May 31, 2019

Commits on May 31, 2019

  1. First draft for deconflicting

    @lukastaegert
    lukastaegert committed May 31, 2019
    Copy the full SHA
    b6e7db6 View commit details
    Browse the repository at this point in the history

  2. Replace objects with Sets and Maps

    @lukastaegert
    lukastaegert committed May 31, 2019
    Copy the full SHA
    49064f3 View commit details
    Browse the repository at this point in the history

  3. Only deconflict format globals if necessary

    @lukastaegert
    lukastaegert committed May 31, 2019
    Copy the full SHA
    1fa898e View commit details
    Browse the repository at this point in the history

  4. Use accessed global variables to optimize wrappers

    @lukastaegert
    lukastaegert committed May 31, 2019
    Copy the full SHA
    39ee6f8 View commit details
    Browse the repository at this point in the history

  5. Use different globals for file accesses

    @lukastaegert
    lukastaegert committed May 31, 2019
    Copy the full SHA
    89a3024 View commit details
    Browse the repository at this point in the history

  6. Use require.toUrl instead of concatenating strings to resolve files f… 

    …or AMD
    @lukastaegert
    lukastaegert committed May 31, 2019
    Copy the full SHA
    bae5b25 View commit details
    Browse the repository at this point in the history