Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reserve error stack information #2871

Merged
merged 4 commits into from May 27, 2019
Merged

Reserve error stack information #2871

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
123c564
Reserve error stack information
LongTengDao May 23, 2019
337f707
fix ts error
LongTengDao May 23, 2019
c2ade6e
Make code looking clear
LongTengDao May 23, 2019
a05dcd5
only left message assignment
LongTengDao May 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/ModuleLoader.ts
View file
Open in desktop
Expand Up @@ -307,11 +307,21 @@ export class ModuleLoader {
)
.catch((err: Error) => {
timeEnd('load modules', 3);
let msg = `Could not load ${id}`;
if (importer) msg += ` (imported by ${importer})`;
const error = new Error('~');

msg += `: ${err.message}`;
throw new Error(msg);
let surfix = error.stack || '';
surfix = surfix.replace('Error: ~', '');

let prefix = `Could not load ${id}`;
if (importer) prefix += ` (imported by ${importer})`;
prefix += ':\n';

const message = err.message || '';
const stack = err.stack || '';
error.message = prefix + message;
error.stack = prefix + stack + surfix;

throw error;
})
.then(source => {
timeEnd('load modules', 3);
Expand Down