Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 999-big-list-of-options.md #2812

Merged
merged 2 commits into from Apr 19, 2019
Merged

Update 999-big-list-of-options.md #2812

merged 2 commits into from Apr 19, 2019

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Apr 18, 2019 •
edited

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

just a doc nit. default is a valid property - quotes are not required.

lukastaegert
lukastaegert approved these changes Apr 19, 2019
View reviewed changes
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. (I guess the reason why people tend to quote ['default'] is compatibility with some ancient IE)

@lukastaegert lukastaegert merged commit 49fbf7d into rollup:master Apr 19, 2019
@dnalborczyk dnalborczyk deleted the patch-1 branch April 19, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dnalborczyk @lukastaegert