Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package issues #2691

Merged
merged 3 commits into from Feb 14, 2019
Merged

Fix package issues #2691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8584345
Fix package issues and update circleci flow
lukastaegert Feb 14, 2019
7c8835e
Update acorn to latest version and change tests, see
lukastaegert Feb 14, 2019
47059b1
Update CircleCI config
lukastaegert Feb 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
62 changes: 19 additions & 43 deletions .circleci/config.yml
View file
Open in desktop
@@ -1,17 +1,16 @@
version: 2

unit_tests: &unit_tests
steps:
- checkout
- restore_cache:
key: dependency-cache-{{ checksum "package-lock.json" }}
- run:
name: NPM Rebuild
command: npm install
- run:
name: Run unit tests.
command: npm run ci:test
version: 2

jobs:
dependency_cache:
analysis:
docker:
- image: rollupcabal/circleci-node-base:latest
steps:
Expand All @@ -20,31 +19,21 @@ jobs:
key: dependency-cache-{{ checksum "package-lock.json" }}
- run:
name: Install Dependencies
command: npm install
command: npm ci
- run:
name: Run linting.
command: npm run lint
- run:
name: Run NPM Security Audit
command: npm run security
- save_cache:
key: dependency-cache-{{ checksum "package-lock.json" }}
paths:
- ./node_modules
node-v6-latest:
docker:
- image: rollupcabal/circleci-node-v6:latest
steps:
- checkout
- restore_cache:
key: dependency-cache-{{ checksum "package-lock.json" }}
- run:
name: NPM Rebuild
command: npm install
- run:
name: Run unit tests.
command: npm run ci:test
# - run:
# name: Run unit tests.
# command: npm run ci:coverage
# - run:
# name: Submit coverage data to codecov.
# command: bash <(curl -s https://codecov.io/bash)
# when: on_success
<<: *unit_tests
node-v8-latest:
docker:
- image: rollupcabal/circleci-node-v8:latest
Expand All @@ -53,32 +42,19 @@ jobs:
docker:
- image: rollupcabal/circleci-node-v10:latest
<<: *unit_tests
analysis:
docker:
- image: rollupcabal/circleci-node-base:latest
steps:
- checkout
- restore_cache:
key: dependency-cache-{{ checksum "package-lock.json" }}
- run:
name: NPM Rebuild
command: npm install
- run:
name: Run linting.
command: npm run lint
- run:
name: Run NPM Security Audit
command: npm run security
# - run:
# name: Run unit tests.
# command: npm run ci:coverage
# - run:
# name: Submit coverage data to codecov.
# command: bash <(curl -s https://codecov.io/bash)
# when: on_success

version: 2.0
workflows:
version: 2
validate-test:
jobs:
- dependency_cache
- analysis:
requires:
- dependency_cache
filters:
tags:
only: /.*/
Expand Down