Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent final resolution and facade creation for inlined dynamic imports #2677

Merged
merged 6 commits into from Feb 17, 2019
Merged

Prevent final resolution and facade creation for inlined dynamic imports #2677

merged 6 commits into from Feb 17, 2019

Commits on Feb 17, 2019

  1. failing test for #2676

    @Rich-Harris @lukastaegert
    Rich-Harris authored and lukastaegert committed Feb 17, 2019
    Copy the full SHA
    a9cb6d2 View commit details
    Browse the repository at this point in the history

  2. skip final resolution if dynamic import has already been rendered

    @Rich-Harris @lukastaegert
    Rich-Harris authored and lukastaegert committed Feb 17, 2019
    Copy the full SHA
    637e677 View commit details
    Browse the repository at this point in the history

  3. add expected test output

    @Rich-Harris @lukastaegert
    Rich-Harris authored and lukastaegert committed Feb 17, 2019
    Copy the full SHA
    beb2c6e View commit details
    Browse the repository at this point in the history

  4. only mark dynamic import as replaced if it was completely overwritten

    @Rich-Harris @lukastaegert
    Rich-Harris authored and lukastaegert committed Feb 17, 2019
    Copy the full SHA
    16221f2 View commit details
    Browse the repository at this point in the history

  5. * only render final resolutions for cross-chunk dynamic imports 

    * do not create facades for inlined dynamic imports
    @lukastaegert
    lukastaegert committed Feb 17, 2019
    Copy the full SHA
    7e6b1cd View commit details
    Browse the repository at this point in the history

  6. Get rid of AppVeyor Node 8 test to speed up CI

    @lukastaegert
    lukastaegert committed Feb 17, 2019
    Copy the full SHA
    f6be470 View commit details
    Browse the repository at this point in the history