Improve how acorn is imported, update dependencies #2636
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Closes #2628
Description
Since acorn unfortunately needs to be external now, there is an issue that only shows when rollup itself is bundled by another ESM aware bundler in that
require('acorn')
to a default importThis is only an issue with the two bundled acorn plugins for dynamic import and import.meta. The solution is to manually import the (more efficient!) ESM version of the dynamic import plugin and translate the remaining import manually in the renderChunk hook. This is not elegant but an error will be thrown if the expected import changes.
Also, some dependencies are updated.