Show how to skip imports for optional plugins #2627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most common Rollup plugins are pretty fast to import (by Node standards), but even those will commonly add on a handful of milliseconds, and it’s not unheard of to have imports literally take seconds. If you don’t need it, why load it? I think that this is a good pattern to recommend. eslint and stylelint are two good examples of unreasonably slow modules that will commonly be optional. stylelint can take a second or two, and eslint a few hundred milliseconds, because neither of them care enough about startup time. stylelint/stylelint#2454 was me reporting it for stylelint. I wish more people used Rollup on their packages before submitting them to npm.
lukastaegert
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most common Rollup plugins are pretty fast to import (by Node standards), but even those will commonly add on a handful of milliseconds, and it’s not unheard of to have imports literally take seconds. If you don’t need it, why load it? I think that this is a good pattern to recommend.
eslint and stylelint are two good examples of unreasonably slow modules that will commonly be optional. stylelint can take a second or two, and eslint a few hundred milliseconds, because neither of them care enough about startup time. stylelint/stylelint#2454 was me reporting it for stylelint. I wish more people used Rollup on their packages before submitting them to npm.