Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove previous cache from memory after graph creation #2496

Merged
merged 2 commits into from Oct 9, 2018

Conversation

edoardocavazza
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This prevent memory usage to blow up with incremental builds.

fixes #2494

lukastaegert
lukastaegert previously approved these changes Oct 7, 2018
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We actually had this in Graph.ts until some point:

delete options.cache; // TODO not deleting it here causes a memory leak; needs further investigation

We have a test for memory leaks that triggered if this did not happen. Not sure why it no longer throws an error.

@lukastaegert lukastaegert dismissed their stale review October 7, 2018 09:01

See #2494 (comment) , would be cool if we could find a working test for this

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukastaegert lukastaegert merged commit a3be30d into rollup:master Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cache option causes incremental memory usage
2 participants