Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix template string #2470

Merged
merged 2 commits into from Sep 21, 2018
Merged

Fix template string #2470

merged 2 commits into from Sep 21, 2018

Conversation

styfle
Copy link
Contributor

@styfle styfle commented Sep 21, 2018

This PR contains:

  • bugfix

Are tests included?

  • yes (bugfixes and features will not be merged without tests)

Breaking Changes?

  • no

List any relevant issue numbers:

Description

This error message should probably use a template string so that pluginName is not a literal but it's value is printed instead.

@styfle
Copy link
Contributor Author

styfle commented Sep 21, 2018

Should I add one more assert to check the error message string includes the plugin name?

assert.equal(err.pluginCode, 'DUPLICATE_PLUGIN_NAME');

Maybe something like assert.equal(err.message.includes(plugin), true);

@shellscape
Copy link
Contributor

@styfle nice catch! yes, please do add a test. definitely would not hurt.

@styfle
Copy link
Contributor Author

styfle commented Sep 21, 2018

@shellscape Done!

@shellscape shellscape merged commit 2d2ae21 into rollup:master Sep 21, 2018
@shellscape
Copy link
Contributor

thanks!

@styfle styfle deleted the patch-1 branch September 21, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants