Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that when providing
input: 'file.js', output: { dir: 'dist' }
, Rollup thinks it is doing a single-file build, but the CLI was providing the error: "You must specify an --output (-o) option when creating a file with a sourcemap" which is completely useless.With this change, the error now provided in this case is "You must specify output.file when doing a single-file input build".
We could perhaps clarify this even more as well.
To clarify the code-splitting logic here:
input
is an array or object to indicate that this is a code-splitting workflow.output.dir
option as the primary indicator that it is a code-splitting workflow because output options only known at generate time, while the type of build has to be determined from the input options already.Happy to reconsider the logic here... perhaps a
codeSplitting: true / false
would make this clearer to users which build they are doing.