Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Required Dependencies Of Rollup In "dependencies" #1965

Merged
merged 1 commit into from Mar 12, 2018

Conversation

chadhietala
Copy link
Contributor

@chadhietala chadhietala commented Feb 12, 2018

This fixes 2 issues:

  1. This ensures that required dependencies of rollup are downloaded on a consumers machine. Right now I think things may be accidentally working.
  2. Fixes the following issue where TypeScript consumers were receiving type errors due to missing type definitions for acorn.

screen shot 2018-02-12 at 2 59 44 pm

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though these dependencies might be required for some of the internal TypeScript types to be working correctly, they are by no means necessary for rollup to work because they are already part of the rollup bundle. The question should be rather how to make the types work without those dependencies that users of rollup do not come into contact with anyway.

@lukastaegert
Copy link
Member

I guess since no better suggestion has been made yet, this will go into the next feature release.

@lukastaegert lukastaegert added this to the 0.57.0 milestone Mar 6, 2018
avgaltsev added a commit to avgaltsev/rollup-plugin-postcss-exports that referenced this pull request Mar 8, 2018
@lukastaegert lukastaegert merged commit cf1968c into rollup:master Mar 12, 2018
@chadhietala chadhietala deleted the include-acorn-types branch March 15, 2018 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants