Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not output getter defs when in legacy mode #1069

Merged
merged 2 commits into from
Dec 12, 2016
Merged

Do not output getter defs when in legacy mode #1069

merged 2 commits into from
Dec 12, 2016

Conversation

IvanSanchez
Copy link
Contributor

@IvanSanchez IvanSanchez commented Oct 20, 2016

This prevents rollup from outputting object getters for reassigned exports (which will trigger a syntax error when Object.freeze() is skipped).

Related to #1068, based on comments from futurist/rollup-plugin-es3#3 , will try to add added a test for this.

@IvanSanchez
Copy link
Contributor Author

FYI, without the fix, the new test fails as so:

  var browserStuff = (Object.freeze || Object)({
-         get browserSpecificThing () { return browserSpecificThing; },
+         browserSpecificThing: browserSpecificThing,
          foo: foo
  });

@mourner mourner mentioned this pull request Nov 3, 2016
10 tasks
@Rich-Harris Rich-Harris merged commit 07eb86c into rollup:master Dec 12, 2016
@Rich-Harris
Copy link
Contributor

Thank you!

@derrickb
Copy link

Hi @Rich-Harris I'm running into this problem now, but there doesn't appear to be a legacy option anymore. Can we reopen this issue? I need getters/setters removed from my output. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants