Upgrade chokidar and fsevents for Apple M1 compatibility #3945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates `chokidar` and `fsevents` in package.json. `fsevents` ~2.1.2 was deprecated, and mentions to use 2.2 or 2.3 instead. This is the message you see when installing rollup as a dependency: `rollup > fsevents@2.1.3: "Please update to latest v2.3 or v2.2"`. The [commits](https://github.com/fsevents/fsevents/commits/master) there imply it's for Apple M1 compatibility. `chokidar` also updated to that version of `fsevents`, so I updated that here too. If you see package-lock.json, you'll see the older version of 2.1.3 got added to mocha's dependencies. They use the older version, and haven't released a new version yet.
Codecov Report
@@ Coverage Diff @@
## master #3945 +/- ##
=======================================
Coverage 97.18% 97.18%
=======================================
Files 188 188
Lines 6685 6685
Branches 1947 1947
=======================================
Hits 6497 6497
Misses 99 99
Partials 89 89 Continue to review full report at Codecov.
|
lukastaegert
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
Thanks. Previously, I was not updating because the updated fsevents was failing on my local non-M1 Mac, see #3931 (comment), but it appears this is working now, so I will merge this.
|
Thanks! A bit confused, the linked issue doesn't seem to be resolved tho? 😐 |
|
True. But it did not break for me this time and well, let's hope it will be resolved eventually. |
threepointone
added a commit
to threepointone/vite
that referenced
this pull request
Feb 6, 2021
The installed version of `fsevents`, ~2.1.2 (2.1.3, to be precise) has issues with Apple M1 machines. So if you use `vite` to create an app, you'll get a warning `vite > fsevents@2.1.3: "Please update to latest v2.3 or v2.2"`. So, this PR updates `fsevents` to 2.3.1. `chokidar` also updated their usage of `fsevents`, so I updated `chokidar` as well to 3.5.1. Both these packages were already available trasnitively. `rollup` updated it's usafe as well (via me, rollup/rollup#3945), so I updated `rollup` here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers: -NA-
Description
This PR updates
chokidarandfseventsin package.json.fsevents~2.1.2 was deprecated, and mentions to use 2.2 or 2.3 instead. This is the message you see when installing rollup as a dependency:rollup > fsevents@2.1.3: "Please update to latest v2.3 or v2.2". The commits there imply it's for Apple M1 compatibility.chokidaralso updated to that version offsevents, so I updated that here too.If you see package-lock.json, you'll see the older version of 2.1.3 got added to mocha's dependencies. They use the older version, and haven't released a new version yet.