Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail for circular imports between manual chunks #3510

Merged
merged 1 commit into from Apr 22, 2020

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3499

Description

There was a missing break-off condition that lead to an infinite recursion when there was a circular dependency between manual chunks.

@rollup-bot
Copy link
Collaborator

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-3499-circular-manual-chunks

or load it into the REPL:
https://rollupjs.org/repl/?circleci=10663

@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #3510 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3510   +/-   ##
=======================================
  Coverage   96.12%   96.12%           
=======================================
  Files         176      176           
  Lines        5983     5984    +1     
  Branches     1761     1762    +1     
=======================================
+ Hits         5751     5752    +1     
  Misses        118      118           
  Partials      114      114           
Impacted Files Coverage Δ
src/Chunk.ts 99.77% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 925d302...8ca6178. Read the comment docs.

@lazka
Copy link

lazka commented Apr 22, 2020

I can confirm that this makes things work again. Thanks!

@lukastaegert lukastaegert merged commit f65bae1 into master Apr 22, 2020
@lukastaegert lukastaegert deleted the gh-3499-circular-manual-chunks branch April 22, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endless recursion error with manual chunking
3 participants