Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless recursion error with manual chunking #3499

Closed
lazka opened this issue Apr 16, 2020 · 1 comment · Fixed by #3510
Closed

Endless recursion error with manual chunking #3499

lazka opened this issue Apr 16, 2020 · 1 comment · Fixed by #3510

Comments

@lazka
Copy link

lazka commented Apr 16, 2020

I'm passing some of my dependencies to manualChunks after updating rollup from 1.x to 2.x I noticed that it fails to build now. See the linked repo for a minimal reproducer. I haven't looked into which version is the last one to work, but I can figure that out if needed.

The culprit is the manualChunks config I pass here: https://github.com/lazka/rollup-chunks-bug/blob/master/rollup.config.js

Expected Behavior

  • Rollup creates separate chunks for my dependencies.

Actual Behavior

  • Rollup crashes:
!] RangeError: Maximum call stack size exceeded
RangeError: Maximum call stack size exceeded
    at Chunk$1.inlineChunkDependencies (/home/lazka/Desktop/adwwad/rollup-bug/node_modules/rollup/dist/shared/rollup.js:16400:28)
    at Chunk$1.inlineChunkDependencies (/home/lazka/Desktop/adwwad/rollup-bug/node_modules/rollup/dist/shared/rollup.js:16411:22)
    at Chunk$1.inlineChunkDependencies (/home/lazka/Desktop/adwwad/rollup-bug/node_modules/rollup/dist/shared/rollup.js:16411:22)
    at Chunk$1.inlineChunkDependencies (/home/lazka/Desktop/adwwad/rollup-bug/node_modules/rollup/dist/shared/rollup.js:16411:22)
    at Chunk$1.inlineChunkDependencies (/home/lazka/Desktop/adwwad/rollup-bug/node_modules/rollup/dist/shared/rollup.js:16411:22)
    at Chunk$1.inlineChunkDependencies (/home/lazka/Desktop/adwwad/rollup-bug/node_modules/rollup/dist/shared/rollup.js:16411:22)
    at Chunk$1.inlineChunkDependencies (/home/lazka/Desktop/adwwad/rollup-bug/node_modules/rollup/dist/shared/rollup.js:16411:22)
    at Chunk$1.inlineChunkDependencies (/home/lazka/Desktop/adwwad/rollup-bug/node_modules/rollup/dist/shared/rollup.js:16411:22)
    at Chunk$1.inlineChunkDependencies (/home/lazka/Desktop/adwwad/rollup-bug/node_modules/rollup/dist/shared/rollup.js:16411:22)
    at Chunk$1.inlineChunkDependencies (/home/lazka/Desktop/adwwad/rollup-bug/node_modules/rollup/dist/shared/rollup.js:16411:22)
@lukastaegert
Copy link
Member

Fix at #3510, thanks for spotting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants