Allow import.meta.* instead of only import.meta.url

[dmail]

Expected Behavior / Situation

I would like that the following code

import.meta.resolve('./file.js')

To output something like this for systemjs format.

System.register([], function (exports, module) {
  return {
    execute: function () {
      module.meta.resolve("./file.js");
    }
  }
});

Actual Behavior / Situation

The output has no module, resulting in a ReferenceError: module is not defined.

System.register([], function (exports) {
  return {
    execute: function () {
      module.meta.resolve("./file.js");
    }
  }
});

Modification Proposal

Make this if less strict.

rollup/src/ast/nodes/MetaProperty.ts

Line 39 in 8df2bc1

if (metaProperty === 'url') {

Adding || metaProperty === 'resolve' works for me.

---

Note by maintainers (by @lukastaegert)

🙋‍♀️ Want to get involved and address this? This issue is likely easy to address and a good starting point to get familiar with the Rollup code base.

The proposed solution is to reverse the linked if statement so that all non-Rollup-internal cases are handled like the generic URL case. It should probably be checked if this assumption makes sense for all formats.

As a test, adding one to the form directory would make sense, as these render the code in all available formats. Look at the other tests how those are written. To validate the code is actually runnable, it could make sense to also add a test to the function directory as those tests compile to CommonJS and actually run the code, but this is optional.

[lukastaegert]

I see your point and it definitely makes sense to have a fallback for other properties. I think a prudent change could be to reverse the if statement: If none of the special cases internal to Rollup are encountered, then ALWAYS add the additional accessed globals.

[lukastaegert]

PR welcome, I added additional notes to the issue description.

[dmail]

I have created the PR to initiate the work.

It would match my need but I'm not very confortable with

'use strict';

undefined('./foo.js');

being the expected output for commonjs format 😅

[lukastaegert]

See my comment on your PR, I think it is a reasonable compromise.

[lukastaegert]

People can still change this by implementing resolveImportMeta

[lukastaegert]

resolved via #3152

[dmail]

Thank you very much 😍

[dasa]

I found that if you just use import.meta like this console.log(import.meta) then module isn't imported for AMD and system formats.

http://rollupjs.org/repl/?version=1.27.10&shareable=JTdCJTIybW9kdWxlcyUyMiUzQSU1QiU3QiUyMm5hbWUlMjIlM0ElMjJtYWluLmpzJTIyJTJDJTIyY29kZSUyMiUzQSUyMmNvbnNvbGUubG9nKGltcG9ydC5tZXRhKSUyMiUyQyUyMmlzRW50cnklMjIlM0F0cnVlJTdEJTVEJTJDJTIyb3B0aW9ucyUyMiUzQSU3QiUyMmZvcm1hdCUyMiUzQSUyMnN5c3RlbSUyMiUyQyUyMm5hbWUlMjIlM0ElMjJteUJ1bmRsZSUyMiUyQyUyMmFtZCUyMiUzQSU3QiUyMmlkJTIyJTNBJTIyJTIyJTdEJTJDJTIyZ2xvYmFscyUyMiUzQSU3QiU3RCU3RCUyQyUyMmV4YW1wbGUlMjIlM0FudWxsJTdE

Is this a bug?

[lukastaegert]

Actually a bug. Fix here: #3282