Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always make "module" available for SystemJS and AMD formats if import.meta is accessed directly #3282

Merged
merged 1 commit into from Dec 13, 2019

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
#3151 (comment)

Description

When import.meta is accessed directly, Rollup would render a polyfill object that accesses module for AMD and SystemJS formats without importing it. This is fixed here.

@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #3282 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3282      +/-   ##
==========================================
- Coverage   93.13%   93.12%   -0.01%     
==========================================
  Files         170      170              
  Lines        5968     5967       -1     
  Branches     1781     1780       -1     
==========================================
- Hits         5558     5557       -1     
  Misses        219      219              
  Partials      191      191
Impacted Files Coverage Δ
src/ast/nodes/MetaProperty.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d94f0e...c93f807. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant