treeshake.moduleSideEffects incorrectly eliminates export * from "external"

[Swatinem]

found here: Swatinem/rollup-plugin-dts#34

• Rollup Version: 1.14.3
• Operating System (or Browser): arch
• Node Version: 11.15

How Do We Reproduce?

No repl, since you can’t set treeshake.moduleSideEffects options.

But its as simple as:

export * from "rollup";

with a rollup config:

treeshake: { moduleSideEffects: "no-external" },
external: ["rollup"],

Expected Behavior

external export * should not be touched, no matter what

Actual Behavior

the whole export * statement is removed.

[lukastaegert]

luckily @lukastaegert is super responsive with all rollup issues :-) ❤️

Thanks for the kind words, let's see how response times change once my paternal leave ends 😉
Fix at #2905

[aleclarson]

@lukastaegert Keep up the great work! ❤️