Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure external re-exports are included for moduleSideEffects: false #2905

Merged
merged 2 commits into from Jun 7, 2019

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #2904

Description

This fixes two things:

  • If an external variable is re-exported, the external variable is always properly included
  • If a module is only implicitly external (i.e. not found), it should still be marked as side-effect free if this configuration holds for external modules.

@lukastaegert lukastaegert merged commit 0a0b67f into master Jun 7, 2019
@lukastaegert lukastaegert deleted the gh-2904-external-reexport-without-side-effect branch June 7, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

treeshake.moduleSideEffects incorrectly eliminates export * from "external"
1 participant