Exports are not being taken into consideration in the hash generation #2692
Labels
Comments
manucorporat
changed the title
|
@lukastaegert I ran into this (after deploying and breaking production 😢) and @manucorporat helped with the repro (I was using Rollup via StencilJS), it's pretty gnarly when you're caching via CDN. |
|
Sorry for this and thanks for the awesome repro. Fix at #2695. |
lukastaegert
added a commit
that referenced
this issue
Feb 16, 2019
lukastaegert
added a commit
that referenced
this issue
Feb 16, 2019
lukastaegert
added a commit
that referenced
this issue
Feb 17, 2019
lukastaegert
added a commit
that referenced
this issue
Feb 17, 2019
* Create hash test type and red test * Consider actually exported names in hash, resolve #2692 * Add tests for other hashing situations and fix addon hashing * Rework test to check hashes and contents of all files and throw if two files with different content share the same hash; fix another issue for exports that was uncovered by this. * Remove unnecessary expectations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
How Do We Reproduce?
https://rollupjs.org/repl?version=1.1.2&shareable=JTdCJTIybW9kdWxlcyUyMiUzQSU1QiU3QiUyMm5hbWUlMjIlM0ElMjJtYWluLmpzJTIyJTJDJTIyY29kZSUyMiUzQSUyMmltcG9ydCUyMCU3QiUyMGZvbyUyQyUyMGJhciUyMCU3RCUyMGZyb20lMjAnLiUyRmRlcCclM0IlNUNuY29uc29sZS5sb2coZm9vKCklMkMlMjBiYXIoKSklM0IlMjIlMkMlMjJpc0VudHJ5JTIyJTNBdHJ1ZSU3RCUyQyU3QiUyMm5hbWUlMjIlM0ElMjJvdGhlckVudHJ5LmpzJTIyJTJDJTIyY29kZSUyMiUzQSUyMmltcG9ydCUyMCU3QiUyMHRoaW5nJTIwJTdEJTIwZnJvbSUyMCcuJTJGZGVwJyUzQiU1Q25jb25zb2xlLmxvZyh0aGluZygpKSUzQiUyMiUyQyUyMmlzRW50cnklMjIlM0F0cnVlJTdEJTJDJTdCJTIybmFtZSUyMiUzQSUyMmRlcC5qcyUyMiUyQyUyMmNvZGUlMjIlM0ElMjJmdW5jdGlvbiUyMGZvbygpJTIwJTdCJTVDbiUyMCUyMHJldHVybiUyMDElM0IlNUNuJTdEJTVDbiU1Q25mdW5jdGlvbiUyMGJhcigpJTIwJTdCJTVDbiUyMCUyMHJldHVybiUyMDIlM0IlNUNuJTdEJTVDbiU1Q25mdW5jdGlvbiUyMHRoaW5nKCklMjAlN0IlNUNuJTIwJTIwcmV0dXJuJTIwYmFyKCklM0IlNUNuJTdEJTVDbiU1Q25leHBvcnQlMjAlN0IlMjBmb28lMkMlMjBiYXIlMkMlMjB0aGluZyUyMCU3RCUzQiUyMiUyQyUyMmlzRW50cnklMjIlM0FmYWxzZSU3RCU1RCUyQyUyMm9wdGlvbnMlMjIlM0ElN0IlMjJmb3JtYXQlMjIlM0ElMjJlc20lMjIlMkMlMjJuYW1lJTIyJTNBJTIybXlCdW5kbGUlMjIlMkMlMjJhbWQlMjIlM0ElN0IlMjJpZCUyMiUzQSUyMiUyMiU3RCUyQyUyMmdsb2JhbHMlMjIlM0ElN0IlN0QlN0QlMkMlMjJleGFtcGxlJTIyJTNBbnVsbCU3RA==
Expected Behavior
When the exports of a chunk changes, that should always result in a change in the hash.
Actual Behavior
When the main.js module does NOT import
bar(), it makes thebar exportto be treeshaken in the chunk, but the filename (hash) is the same.Problematic
This actually breaks some production websites using strong caching, since, it's using a cached module that DOES NOT have some exports.
The text was updated successfully, but these errors were encountered: