Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect rendered exports when generating chunk hashes #2695

Merged
merged 7 commits into from Feb 17, 2019

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #2692

Description

Thanks to @manucorporat we had a nice reproduction for a situation where different rendered exports produced the same hash.
Besides fixing this issue, this motivated me to finally add a dedicated and rather powerful new test suite for hash scenarios where basically in each test, two very similar bundles are created and an error is thrown if any two files are generated that have the same hash but different content.

@manucorporat
Copy link
Contributor

manucorporat commented Feb 15, 2019

Thanks a lot for the fix! and so happy to see so much new tests!! you are a beast!

@lukastaegert lukastaegert force-pushed the gh-2692-respect-exports-in-hashes branch from 8c65e47 to 31a999d Compare February 16, 2019 10:09
@lukastaegert lukastaegert merged commit 4d082b0 into master Feb 17, 2019
@lukastaegert lukastaegert deleted the gh-2692-respect-exports-in-hashes branch February 17, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exports are not being taken into consideration in the hash generation
2 participants