Fix support for BigInt literals when using the acorn plugin #2640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Closes #2626
Description
This should address the following issues when using the acorn-bigint plugin:
Math.pow
when checking conditionals on newer environmentsAt the moment to ensure Node 6 compatibility, "**" will be transpiled to
Math.pow
which does not support bigints. At the same time, the acorn plugin will wrongly mark bigint literals to have the value "null" on older systems that do not support them. This solves those issues by treating bigint literals as "unknown" on all systems. Theoretically, it would also be possible to leave them as literals on newer environments and just fix theMath.pow
issue but then this would make testing much harder and I was lazy.