Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship with bigint support built-in #2789

Merged
merged 2 commits into from Apr 5, 2019

Conversation

danielgindi
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

As BigInt is already stage 3, and supported in all major browsers and in Node.js for a long time now (in node it landed in v10.4.0 - 2018-06-06),
It makes sense to ship with builtin BigInt support.
More and more code contains BigInt literals, and adding acorn plugins is a walk in the park, on a break from hell duties.

This PR makes acorn-bigint automatically added to acorn like other plugins already do (acorn-import-meta, acorn-dynamic-import).
The tests are kept the same - except for now they don't explicitly add the plugin.

Related to #2640

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot!

@lukastaegert lukastaegert merged commit c3d67ca into rollup:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants