Inline docs #2602
Merged
Inline docs #2602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
approved these changes
Dec 20, 2018
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -8,6 +8,7 @@ | |||
| Pull Request Requirements: | |||
| * Please include tests to illustrate the problem this PR resolves. | |||
| * Please lint your changes by running `npm run lint` before creating a PR. | |||
| * Please update the documentation in `/guide` where necessary | |||
There was a problem hiding this comment.
Nit: could we call it docs over guide?
sstur
reviewed
Feb 16, 2019
| ```javascript | ||
| // rollup.config.js | ||
| import fetch from 'node-fetch'; | ||
| export default fetch('/some-remote-service-or-file-which-returns-actual-config'); |
There was a problem hiding this comment.
I think there might be a small mistake with these promise examples using fetch.
fetch() returns a promise that resolves to a Response which represents a status and a set of HTTP headers, etc. It does contain the response body and does not resolve to a plain object. In this example, you probably need to do something like:
export default fetch('/some-remote-service-or-file-which-returns-actual-config').then(response => response.json());Here is the Reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #2270.
Description
This will inline the documentation into rollup. This is the minimal version for now: Just the documentation, no website. The corresponding website PR is rollup/rollupjs.org#172