Add tests and slightly adapt logic

src/ast/nodes/AssignmentExpression.ts

@@ -29,7 +29,7 @@ export default class AssignmentExpression extends NodeBase {
 	private deoptimized = false;
 
 	hasEffects(context: HasEffectsContext): boolean {
-		this.deoptimize();
+		if (!this.deoptimized) this.applyDeoptimizations();
 		return (
 			this.right.hasEffects(context) ||
 			this.left.hasEffects(context) ||
@@ -41,9 +41,11 @@ export default class AssignmentExpression extends NodeBase {
 		return path.length > 0 && this.right.hasEffectsWhenAccessedAtPath(path, context);
 	}
 
-	include(context: InclusionContext, includeChildrenRecursively: IncludeChildren) {
-		this.deoptimize();
-		return super.include(context, includeChildrenRecursively);
+	include(context: InclusionContext, includeChildrenRecursively: IncludeChildren): void {
+		if (!this.deoptimized) this.applyDeoptimizations();
+		this.included = true;
+		this.left.include(context, includeChildrenRecursively);
+		this.right.include(context, includeChildrenRecursively);
 	}
 
 	render(code: MagicString, options: RenderOptions) {
@@ -80,16 +82,9 @@ export default class AssignmentExpression extends NodeBase {
 		}
 	}
 
-	shouldBeIncluded(context: InclusionContext): boolean {
-		this.deoptimize();
-		return super.shouldBeIncluded(context);
-	}
-
-	private deoptimize() {
-		if (!this.deoptimized) {
-			this.deoptimized = true;
-			this.left.deoptimizePath(EMPTY_PATH);
-			this.right.deoptimizePath(UNKNOWN_PATH);
-		}
+	private applyDeoptimizations() {
+		this.deoptimized = true;
+		this.left.deoptimizePath(EMPTY_PATH);
+		this.right.deoptimizePath(UNKNOWN_PATH);
 	}
 }

test/function/samples/assignment-deoptimization/assignee-is-deoptimized/_config.js

@@ -0,0 +1,3 @@
+module.exports = {
+	description: 'makes sure the assignee is deoptimized'
+};

test/function/samples/assignment-deoptimization/assignee-is-deoptimized/main.js

@@ -0,0 +1,5 @@
+const flags = { updated: false };
+let toBeUpdated = {};
+toBeUpdated = flags;
+toBeUpdated.updated = true;
+if (!flags.updated) throw new Error('Update was not tracked');

test/function/samples/assignment-deoptimization/assignment-target-is-deoptimized/_config.js

@@ -0,0 +1,3 @@
+module.exports = {
+	description: 'makes sure the assignment target is deoptimized'
+};

test/function/samples/assignment-deoptimization/assignment-target-is-deoptimized/main.js

@@ -0,0 +1,3 @@
+let updated = false;
+updated = true;
+if (!updated) throw new Error('Update was not tracked');

test/function/samples/assignment-deoptimization/nested-assignment/_config.js

@@ -0,0 +1,3 @@
+module.exports = {
+	description: 'tracks assigments nested in expressions that are included for other reasons'
+};

test/function/samples/assignment-deoptimization/nested-assignment/main.js

@@ -0,0 +1,3 @@
+let updated = false;
+assert.ok(!updated) || (updated = true);
+if (!updated) throw new Error('Update was not tracked');

test/function/samples/assignment-deoptimization/try-catch-inclusion/_config.js

@@ -0,0 +1,3 @@
+module.exports = {
+	description: 'tracks assigments included via try-catch-deoptimization'
+};

test/function/samples/assignment-deoptimization/try-catch-inclusion/main.js

@@ -0,0 +1,6 @@
+let updated = false;
+try {
+	updated = true;
+} catch (err) {}
+
+if (!updated) throw new Error('Update was not tracked');