Correctly simplify assignments with parentheses (#3926)

src/ast/nodes/AssignmentExpression.ts

@@ -76,7 +76,8 @@ export default class AssignmentExpression extends NodeBase {
 			this.right.render(code, options, {
 				renderedParentType: renderedParentType || this.parent.type
 			});
-			code.remove(this.start, this.right.start);
+			const operatorPos = findFirstOccurrenceOutsideComment(code.original, '=', this.left.end);
+			code.remove(this.start, findNonWhiteSpace(code.original, operatorPos + 1));
 		}
 		if (options.format === 'system') {
 			const exportNames =

src/utils/renderHelpers.ts

@@ -50,11 +50,12 @@ export function findFirstOccurrenceOutsideComment(code: string, searchString: st
 	}
 }
 
-const WHITESPACE = /\s/;
+const NON_WHITESPACE = /\S/g;
 
 export function findNonWhiteSpace(code: string, index: number) {
-	while (index < code.length && WHITESPACE.test(code[index])) index++;
-	return index;
+	NON_WHITESPACE.lastIndex = index;
+	const result = NON_WHITESPACE.exec(code)!;
+	return result.index;
 }
 
 // This assumes "code" only contains white-space and comments

test/function/samples/unused-parenthesed-assignment/_config.js

@@ -0,0 +1,6 @@
+module.exports = {
+	description: 'correctly simplifies assignments with right-hand-sides in parentheses (#3924)',
+	context: {
+		someObject: { isTrue: true }
+	}
+};

test/function/samples/unused-parenthesed-assignment/main.js

@@ -0,0 +1,2 @@
+let unused = false;
+unused = (someObject.isTrue === true);