Skip to content

Commit

Permalink
Replace deprecated folder export with pattern export (#3896)
Browse files Browse the repository at this point in the history
  • Loading branch information
@lukastaegert
lukastaegert committed Dec 3, 2020
1 parent 11315fd commit bbfdedd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
View file
Expand Up @@ -141,7 +141,7 @@
},
"default": "./dist/es/rollup.browser.js"
},
"./dist/": "./dist/"
"./dist/*": "./dist/*"
},
"dependencies": {
"fsevents": "~2.1.2"
Expand Down

2 comments on commit bbfdedd

@Crenshinibon
Copy link

@Crenshinibon Crenshinibon commented on bbfdedd Dec 5, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'm not sure why my previous comment isn't visible here. But I think this change is wrong and prevents 'others' (in my case cy-rollup) to error when they require('rollup/dist/loadConfigFile') ...

Check out the docs regarding subpath patterns:
https://nodejs.org/api/packages.html#packages_subpath_patterns

I think you need to do: "./dist/*": "./dist/*.js"

Changing this locally brings everything back to normal for me.

@Crenshinibon
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for bothering you on multiple places, I just realized that my previous comment was on the pull request.

Please sign in to comment.