[feat] Adds support for large assets (> 100 MB) (#3194)

* Updates crypto library * missed one * Using charCodeAt instead of TextEncoder * updated lock * Using hash.js for the browser build * review
rollup · Oct 27, 2019 · b4c8b43 · b4c8b43
1 parent b123169
commit b4c8b43
Show file tree

Hide file tree

Showing 8 changed files with 34 additions and 39 deletions.
diff --git a/LICENSE.md b/LICENSE.md
@@ -150,13 +150,13 @@ Repository: jonschlinkert/fill-range
 ## hash.js
 License: MIT
 By: Fedor Indutny
-Repository: git@github.com:indutny/hash.js
+Repository: git+ssh://git@github.com/indutny/hash.js.git
 
 ---------------------------------------
 
 ## inherits
 License: ISC
-Repository: git://github.com/isaacs/inherits
+Repository: git://github.com/isaacs/inherits.git
 
 > The ISC License
 > 
@@ -265,7 +265,7 @@ Repository: micromatch/micromatch
 
 ## minimalistic-assert
 License: ISC
-Repository: https://github.com/calvinmetcalf/minimalistic-assert.git
+Repository: git+https://github.com/calvinmetcalf/minimalistic-assert.git
 
 > Copyright 2015 Calvin Metcalf
 > 

diff --git a/browser/crypto.ts b/browser/crypto.ts
@@ -0,0 +1,3 @@
+import sha256 from 'hash.js/lib/hash/sha/256';
+
+export const createHash = () => sha256();
diff --git a/package-lock.json b/package-lock.json
diff --git a/rollup.config.js b/rollup.config.js
@@ -171,7 +171,7 @@ export default command => {
 			!command.configTest && license({ thirdParty: generateLicenseFile })
 		],
 		// acorn needs to be external as some plugins rely on a shared acorn instance
-		external: ['acorn', 'assert', 'events', 'fs', 'module', 'path', 'util'],
+		external: ['acorn', 'assert', 'crypto', 'events', 'fs', 'module', 'path', 'util'],
 		treeshake,
 		output: {
 			banner,
@@ -205,6 +205,7 @@ export default command => {
 			json(),
 			{
 				load: id => {
+					if (~id.indexOf('crypto.ts')) return fs.readFileSync('browser/crypto.ts', 'utf-8');
 					if (~id.indexOf('fs.ts')) return fs.readFileSync('browser/fs.ts', 'utf-8');
 					if (~id.indexOf('path.ts')) return fs.readFileSync('browser/path.ts', 'utf-8');
 				}

diff --git a/src/Chunk.ts b/src/Chunk.ts
@@ -1,5 +1,5 @@
-import sha256 from 'hash.js/lib/hash/sha/256';
 import MagicString, { Bundle as MagicStringBundle, SourceMap } from 'magic-string';
+import { createHash } from '../browser/crypto';
 import { relative } from '../browser/path';
 import { createInclusionContext } from './ast/ExecutionContext';
 import ExportDefaultDeclaration from './ast/nodes/ExportDefaultDeclaration';
@@ -366,7 +366,7 @@ export default class Chunk {
 	getRenderedHash(): string {
 		if (this.renderedHash) return this.renderedHash;
 		if (!this.renderedSource) return '';
-		const hash = sha256();
+		const hash = createHash();
 		const hashAugmentation = this.calculateHashAugmentation();
 		hash.update(hashAugmentation);
 		hash.update(this.renderedSource.toString());
@@ -860,11 +860,11 @@ export default class Chunk {
 		options: OutputOptions,
 		existingNames: Record<string, any>
 	): string {
-		const hash = sha256();
+		const hash = createHash();
 		hash.update(
 			[addons.intro, addons.outro, addons.banner, addons.footer].map(addon => addon || '').join(':')
 		);
-		hash.update(options.format);
+		hash.update(options.format as string);
 		this.visitDependencies(dep => {
 			if (dep instanceof ExternalModule) {
 				hash.update(':' + dep.renderPath);

diff --git a/src/utils/FileEmitter.ts b/src/utils/FileEmitter.ts
@@ -1,9 +1,9 @@
-import sha256 from 'hash.js/lib/hash/sha/256';
 import Chunk from '../Chunk';
 import Graph from '../Graph';
 import Module from '../Module';
 import { FilePlaceholder, OutputBundleWithPlaceholders } from '../rollup/types';
 import { BuildPhase } from './buildPhase';
+import { createHash } from './crypto';
 import {
 	errAssetNotFinalisedForFileName,
 	errAssetReferenceIdNotFoundForSetSource,
@@ -33,7 +33,7 @@ function generateAssetFileName(
 	return makeUnique(
 		renderNamePattern(output.assetFileNames, 'output.assetFileNames', {
 			hash() {
-				const hash = sha256();
+				const hash = createHash();
 				hash.update(emittedName);
 				hash.update(':');
 				hash.update(source);
@@ -290,7 +290,7 @@ export class FileEmitter {
 	private assignReferenceId(file: ConsumedFile, idBase: string): string {
 		let referenceId: string | undefined;
 		do {
-			const hash = sha256();
+			const hash = createHash();
 			if (referenceId) {
 				hash.update(referenceId);
 			} else {

diff --git a/src/utils/crypto.ts b/src/utils/crypto.ts
@@ -0,0 +1,3 @@
+import { createHash as cryptoCreateHash } from 'crypto';
+
+export const createHash = () => cryptoCreateHash('sha256');
diff --git a/typings/Chunk.d.ts → typings/hash.js.d.ts b/typings/Chunk.d.ts → typings/hash.js.d.ts
@@ -1,6 +1,6 @@
 declare module 'hash.js/lib/hash/sha/256' {
 	export default function sha256(): {
-		update: (data: any) => void;
 		digest: (format: string) => string;
+		update: (data: any) => void;
 	};
 }