Fix treeshaken parameters around parentheses (#2911)

rollup · Jun 9, 2019 · a10a4fb · a10a4fb
1 parent 6652a3e
commit a10a4fb
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/src/ast/nodes/CallExpression.ts b/src/ast/nodes/CallExpression.ts
@@ -248,7 +248,14 @@ export default class CallExpression extends NodeBase implements DeoptimizableEnt
 					for (let index = 0; index <= lastIncludedIndex; index++) {
 						this.arguments[index].render(code, options);
 					}
-					code.remove(this.arguments[lastIncludedIndex].end, this.end - 1);
+					code.remove(
+						findFirstOccurrenceOutsideComment(
+							code.original,
+							',',
+							this.arguments[lastIncludedIndex].end
+						),
+						this.end - 1
+					);
 				} else {
 					code.remove(
 						findFirstOccurrenceOutsideComment(code.original, '(', this.callee.end) + 1,

diff --git a/test/form/samples/treeshake-excess-arguments/arrow-function-arguments/_expected.js b/test/form/samples/treeshake-excess-arguments/arrow-function-arguments/_expected.js
@@ -8,3 +8,5 @@ const needed22 = 2;
 const needed23 = 3;
 
 someUsedParams(needed21, needed22, needed23);
+someUsedParams(needed21, needed22, (needed23));
+(someUsedParams)(needed21, needed22, needed23  );
diff --git a/test/form/samples/treeshake-excess-arguments/arrow-function-arguments/main.js b/test/form/samples/treeshake-excess-arguments/arrow-function-arguments/main.js
@@ -11,3 +11,5 @@ const needed22 = 2;
 const needed23 = 3;
 
 someUsedParams(needed21, needed22, needed23, unneeded2);
+someUsedParams(needed21, needed22, (needed23), unneeded2);
+(someUsedParams)(needed21, needed22, needed23  , unneeded2);