Use new deprecation API for transform dependencies

src/ast/nodes/MetaProperty.ts

@@ -73,7 +73,6 @@ export default class MetaProperty extends NodeBase {
 			const relativePath = normalize(relative(dirname(chunkId), fileName));
 			let replacement;
 			if (assetReferenceId !== null) {
-				// deprecated hook for assets
 				replacement = pluginDriver.hookFirstSync('resolveAssetUrl', [
 					{
 						assetFileName: fileName,

src/utils/transform.ts

@@ -61,17 +61,17 @@ export default function transform(
 				}
 			}
 		} else {
-			// assets emitted by transform are transformDependencies
+			// assets/chunks emitted by a transform hook need to be emitted again if the hook is skipped
 			if (emittedAssets.length) module.transformAssets = emittedAssets;
 			if (emittedChunks.length) module.transformChunks = emittedChunks;
 
 			if (result && typeof result === 'object' && Array.isArray(result.dependencies)) {
 				// not great, but a useful way to track this without assuming WeakMap
 				if (!(curPlugin as any).warnedTransformDependencies)
-					this.warn({
-						code: 'TRANSFORM_DEPENDENCIES_DEPRECATED',
-						message: `Returning "dependencies" from plugin transform hook is deprecated for using this.addWatchFile() instead.`
-					});
+					graph.warnDeprecation(
+						`Returning "dependencies" from the "transform" hook as done by plugin ${plugin.name} is deprecated. The "this.addWatchFile" plugin context function should be used instead.`,
+						true
+					);
 				(curPlugin as any).warnedTransformDependencies = true;
 				if (!transformDependencies) transformDependencies = [];
 				for (const dep of result.dependencies)

test/function/samples/deprecations/transform-dependencies/_config.js

@@ -0,0 +1,19 @@
+const path = require('path');
+
+module.exports = {
+	description: 'marks transform dependencies as deprecated',
+	options: {
+		plugins: {
+			transform(code) {
+				return { code, dependencies: [] };
+			}
+		}
+	},
+	error: {
+		code: 'PLUGIN_ERROR',
+		id: path.resolve(__dirname, 'main.js'),
+		message:
+			'Returning "dependencies" from the "transform" hook as done by plugin at position 1 is deprecated. The "this.addWatchFile" plugin context function should be used instead.',
+		pluginCode: 'DEPRECATED_FEATURE'
+	}
+};

test/function/samples/deprecations/transform-dependencies/main.js

@@ -0,0 +1,11 @@
+const foo = {};
+
+function doIt(x) {
+	if (foo[x]) {
+		return true;
+	}
+	foo[x] = true;
+}
+
+doIt('x');
+assert.ok(doIt('x'), 'foo was not reassigned');

test/hooks/index.js

@@ -1299,46 +1299,6 @@ module.exports = input;
 		});
 	});
 
-	it('Warns when using deprecated transform dependencies in plugins', () => {
-		let warned = false;
-		const watcher = rollup.watch({
-			input: 'input',
-			output: {
-				file: 'asdf',
-				format: 'es'
-			},
-			onwarn(warning) {
-				warned = true;
-				assert.equal(warning.code, 'PLUGIN_WARNING');
-				assert.equal(warning.pluginCode, 'TRANSFORM_DEPENDENCIES_DEPRECATED');
-				assert.equal(
-					warning.message,
-					'Returning "dependencies" from plugin transform hook is deprecated for using this.addWatchFile() instead.'
-				);
-				// throw here to stop file system write
-				throw new Error('STOP');
-			},
-			plugins: [
-				loader({ input: `alert('hello')` }),
-				{
-					name: 'x',
-					transform(code) {
-						return { code, dependencies: [] };
-					}
-				}
-			]
-		});
-		return new Promise((resolve, reject) => {
-			watcher.on('event', evt => {
-				if (evt.code === 'END') resolve();
-				else if (evt.code === 'ERROR' || evt.code === 'FATAL') reject(evt.error);
-			});
-		}).catch(err => {
-			assert.equal(err.message, 'STOP');
-			assert.equal(warned, true);
-		});
-	});
-
 	it('assigns chunk IDs before creating outputBundle chunks', () => {
 		const chunks = [];
 		return rollup