Skip to content

Commit

Permalink
add remaining deprecated string prototype methods
Browse files Browse the repository at this point in the history
  • Loading branch information
dnalborczyk committed Dec 19, 2021
1 parent 0835932 commit 961b84c
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 6 deletions.
21 changes: 18 additions & 3 deletions src/ast/values.ts
Expand Up @@ -163,15 +163,26 @@ const literalNumberMembers: MemberDescriptions = assembleMemberDescriptions(

const literalStringMembers: MemberDescriptions = assembleMemberDescriptions(
{
// note on DEPRECATED methods:
// we still have support until being removed from engines (if ever)
anchor: returnsString, // DEPRECATED
at: returnsUnknown,
big: returnsString, // DEPRECATED
blink: returnsString, // DEPRECATED
bold: returnsString, // DEPRECATED
charAt: returnsString,
charCodeAt: returnsNumber,
codePointAt: returnsUnknown,
concat: returnsString,
endsWith: returnsBoolean,
fixed: returnsString, // DEPRECATED
fontcolor: returnsString, // DEPRECATED
fontsize: returnsString, // DEPRECATED
includes: returnsBoolean,
indexOf: returnsNumber,
italics: returnsString, // DEPRECATED
lastIndexOf: returnsNumber,
link: returnsString, // DEPRECATED
localeCompare: returnsNumber,
match: returnsUnknown,
matchAll: returnsUnknown,
Expand All @@ -193,18 +204,22 @@ const literalStringMembers: MemberDescriptions = assembleMemberDescriptions(
},
search: returnsNumber,
slice: returnsString,
small: returnsString, // DEPRECATED
split: returnsUnknown,
startsWith: returnsBoolean,
substr: returnsString, // deprecated
strike: returnsString, // DEPRECATED
sub: returnsString, // DEPRECATED
substr: returnsString, // DEPRECATED
substring: returnsString,
sup: returnsString, // DEPRECATED
toLocaleLowerCase: returnsString,
toLocaleUpperCase: returnsString,
toLowerCase: returnsString,
toUpperCase: returnsString,
trim: returnsString,
trimEnd: returnsString,
trimLeft: returnsString, // deprecated, alias for trimStart
trimRight: returnsString, // deprecated, alias for trimEnd
trimLeft: returnsString, // DEPRECATED, alias for trimStart
trimRight: returnsString, // DEPRECATED, alias for trimEnd
trimStart: returnsString,
valueOf: returnsString
},
Expand Down
22 changes: 19 additions & 3 deletions test/form/samples/builtin-prototypes/literal/main.js
Expand Up @@ -53,18 +53,34 @@ const _search = 'ab'.search( /a/ ).toExponential( 2 );
const _slice = 'ab'.slice( 0, 1 ).trim();
const _split = 'ab'.split( 'a' );
const _startsWith = 'ab'.startsWith( 'a' ).valueOf();
const _substr = 'ab'.substr( 0, 1 ).trim();
const _substring = 'ab'.substring( 0, 1 ).trim();
const _toLocaleLowerCase = 'ab'.toLocaleLowerCase().trim();
const _toLocaleUpperCase = 'ab'.toLocaleUpperCase().trim();
const _toLowerCase = 'ab'.toLowerCase().trim();
const _toUpperCase = 'ab'.toUpperCase().trim();
const _trim = 'ab'.trim().trim();
const _trimEnd = 'ab'.trimEnd().trim();
const _trimLeft = 'ab'.trimLeft().trim();
const _trimRight = 'ab'.trimRight().trim();
const _trimStart = 'ab'.trimStart().trim();
const _stringValueOf = 'ab'.valueOf().trim();

// DEPRECATED prototype methods
const _anchor = 'ab'.anchor().trim();
const _big = 'ab'.big().trim();
const _blink = 'ab'.blink().trim();
const _bold = 'ab'.bold().trim();
const _fixed = 'ab'.fixed().trim();
const _fontcolor = 'ab'.fontcolor().trim();
const _fontsize = 'ab'.fontsize().trim();
const _italics = 'ab'.italics().trim();
const _link = 'ab'.link().trim();
const _small = 'ab'.small().trim();
const _strike = 'ab'.strike().trim();
const _sub = 'ab'.sub().trim();
const _substr = 'ab'.substr(0, 1).trim();
const _sup = 'ab'.sup().trim();
const _trimLeft = 'ab'.trimLeft().trim();
const _trimRight = 'ab'.trimRight().trim();

// inherited
const _stringHasOwnProperty = 'ab'.hasOwnProperty( 'toString' ).valueOf();
const _stringIsPrototypeOf = 'ab'.isPrototypeOf( '' ).valueOf();
Expand Down

0 comments on commit 961b84c

Please sign in to comment.