Export updated assignments when using shorthand update assignment exp…

…ressions in SystemJS (#3242)

src/ast/nodes/AssignmentExpression.ts

@@ -1,5 +1,5 @@
 import MagicString from 'magic-string';
-import { RenderOptions } from '../../utils/renderHelpers';
+import { findFirstOccurrenceOutsideComment, RenderOptions } from '../../utils/renderHelpers';
 import { getSystemExportStatement } from '../../utils/systemJsRendering';
 import { HasEffectsContext } from '../ExecutionContext';
 import { EMPTY_PATH, ObjectPath, UNKNOWN_PATH } from '../utils/PathTracker';
@@ -51,9 +51,19 @@ export default class AssignmentExpression extends NodeBase {
 		this.right.render(code, options);
 		if (options.format === 'system') {
 			if (this.left.variable && this.left.variable.exportName) {
-				code.prependLeft(
-					code.original.indexOf('=', this.left.end) + 1,
-					` exports('${this.left.variable.exportName}',`
+				const operatorPos = findFirstOccurrenceOutsideComment(
+					code.original,
+					this.operator,
+					this.left.end
+				);
+				const operation =
+					this.operator.length > 1
+						? ` ${this.left.variable.exportName} ${this.operator.slice(0, -1)}`
+						: '';
+				code.overwrite(
+					operatorPos,
+					operatorPos + this.operator.length,
+					`= exports('${this.left.variable.exportName}',${operation}`
 				);
 				code.appendLeft(this.right.end, `)`);
 			} else if ('addExportedVariables' in this.left) {

src/utils/renderHelpers.ts

@@ -30,7 +30,7 @@ export function findFirstOccurrenceOutsideComment(code: string, searchString: st
 	searchPos = code.indexOf(searchString, start);
 	while (true) {
 		start = code.indexOf('/', start);
-		if (start === -1 || start > searchPos) return searchPos;
+		if (start === -1 || start >= searchPos) return searchPos;
 		charCodeAfterSlash = code.charCodeAt(++start);
 		++start;
 
@@ -116,13 +116,13 @@ export function getCommaSeparatedNodesWithBoundaries<N extends Node>(
 	code: MagicString,
 	start: number,
 	end: number
-): ({
+): {
 	contentEnd: number;
 	end: number;
 	node: N;
 	separator: number | null;
 	start: number;
-})[] {
+}[] {
 	const splitUpNodes = [];
 	let node, nextNode, nextNodeStart, contentEnd, char;
 	let separator = start - 1;

test/form/samples/export-live-bindings/_expected/system.js

@@ -10,7 +10,7 @@ System.register('iife', [], function (exports) {
       });
 
       function update () {
-        foo += exports('foo', 10);
+        foo = exports('foo', foo + 10);
       }
 
       let foo = exports('foo', 10);

test/form/samples/updating-assignments/_config.js

@@ -0,0 +1,4 @@
+module.exports = {
+	description: 'Correctly handles assignment operators on exports',
+	options: { output: { name: 'bundle' } }
+};

test/form/samples/updating-assignments/_expected/amd.js

@@ -0,0 +1,20 @@
+define(['exports'], function (exports) { 'use strict';
+
+	exports.x = 1;
+	exports.x = 2;
+	exports.x += 1;
+	exports.x -= 1;
+	exports.x *= 2;
+	exports.x /= 2;
+	exports.x %= 2;
+	exports.x **= 2;
+	exports.x <<= 1;
+	exports.x >>= 1;
+	exports.x >>>= 1;
+	exports.x &= 3;
+	exports.x ^= 2;
+	exports.x |= 2;
+
+	Object.defineProperty(exports, '__esModule', { value: true });
+
+});

test/form/samples/updating-assignments/_expected/cjs.js

@@ -0,0 +1,18 @@
+'use strict';
+
+Object.defineProperty(exports, '__esModule', { value: true });
+
+exports.x = 1;
+exports.x = 2;
+exports.x += 1;
+exports.x -= 1;
+exports.x *= 2;
+exports.x /= 2;
+exports.x %= 2;
+exports.x **= 2;
+exports.x <<= 1;
+exports.x >>= 1;
+exports.x >>>= 1;
+exports.x &= 3;
+exports.x ^= 2;
+exports.x |= 2;

test/form/samples/updating-assignments/_expected/es.js

@@ -0,0 +1,16 @@
+let x = 1;
+x = 2;
+x += 1;
+x -= 1;
+x *= 2;
+x /= 2;
+x %= 2;
+x **= 2;
+x <<= 1;
+x >>= 1;
+x >>>= 1;
+x &= 3;
+x ^= 2;
+x |= 2;
+
+export { x };

test/form/samples/updating-assignments/_expected/iife.js

@@ -0,0 +1,21 @@
+var bundle = (function (exports) {
+	'use strict';
+
+	exports.x = 1;
+	exports.x = 2;
+	exports.x += 1;
+	exports.x -= 1;
+	exports.x *= 2;
+	exports.x /= 2;
+	exports.x %= 2;
+	exports.x **= 2;
+	exports.x <<= 1;
+	exports.x >>= 1;
+	exports.x >>>= 1;
+	exports.x &= 3;
+	exports.x ^= 2;
+	exports.x |= 2;
+
+	return exports;
+
+}({}));

test/form/samples/updating-assignments/_expected/system.js

@@ -0,0 +1,23 @@
+System.register('bundle', [], function (exports) {
+	'use strict';
+	return {
+		execute: function () {
+
+			let x = exports('x', 1);
+			x = exports('x', 2);
+			x = exports('x', x + 1);
+			x = exports('x', x - 1);
+			x = exports('x', x * 2);
+			x = exports('x', x / 2);
+			x = exports('x', x % 2);
+			x = exports('x', x ** 2);
+			x = exports('x', x << 1);
+			x = exports('x', x >> 1);
+			x = exports('x', x >>> 1);
+			x = exports('x', x & 3);
+			x = exports('x', x ^ 2);
+			x = exports('x', x | 2);
+
+		}
+	};
+});

test/form/samples/updating-assignments/_expected/umd.js

@@ -0,0 +1,24 @@
+(function (global, factory) {
+	typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports) :
+	typeof define === 'function' && define.amd ? define(['exports'], factory) :
+	(global = global || self, factory(global.bundle = {}));
+}(this, (function (exports) { 'use strict';
+
+	exports.x = 1;
+	exports.x = 2;
+	exports.x += 1;
+	exports.x -= 1;
+	exports.x *= 2;
+	exports.x /= 2;
+	exports.x %= 2;
+	exports.x **= 2;
+	exports.x <<= 1;
+	exports.x >>= 1;
+	exports.x >>>= 1;
+	exports.x &= 3;
+	exports.x ^= 2;
+	exports.x |= 2;
+
+	Object.defineProperty(exports, '__esModule', { value: true });
+
+})));

test/form/samples/updating-assignments/main.js

@@ -0,0 +1,14 @@
+export let x = 1;
+x = 2;
+x += 1;
+x -= 1;
+x *= 2;
+x /= 2;
+x %= 2;
+x **= 2;
+x <<= 1;
+x >>= 1;
+x >>>= 1;
+x &= 3;
+x ^= 2;
+x |= 2;