Improve coverage

rollup · Jul 24, 2021 · 6ca5536 · 6ca5536
1 parent 16127ed
commit 6ca5536
Show file tree

Hide file tree

Showing 10 changed files with 42 additions and 28 deletions.
diff --git a/src/ast/nodes/MemberExpression.ts b/src/ast/nodes/MemberExpression.ts
@@ -127,7 +127,7 @@ export default class MemberExpression extends NodeBase implements DeoptimizableE
 		if (this.variable) {
 			this.variable.deoptimizePath(path);
 		} else if (!this.replacement) {
-			if (path.length <= MAX_PATH_DEPTH) {
+			if (path.length < MAX_PATH_DEPTH) {
 				this.object.deoptimizePath([this.getPropertyKey(), ...path]);
 			}
 		}
@@ -142,7 +142,7 @@ export default class MemberExpression extends NodeBase implements DeoptimizableE
 		if (this.variable) {
 			this.variable.deoptimizeThisOnEventAtPath(event, path, thisParameter, recursionTracker);
 		} else if (!this.replacement) {
-			if (path.length <= MAX_PATH_DEPTH) {
+			if (path.length < MAX_PATH_DEPTH) {
 				this.object.deoptimizeThisOnEventAtPath(
 					event,
 					[this.getPropertyKey(), ...path],
@@ -167,7 +167,7 @@ export default class MemberExpression extends NodeBase implements DeoptimizableE
 			return UnknownValue;
 		}
 		this.expressionsToBeDeoptimized.push(origin);
-		if (path.length <= MAX_PATH_DEPTH) {
+		if (path.length < MAX_PATH_DEPTH) {
 			return this.object.getLiteralValueAtPath(
 				[this.getPropertyKey(), ...path],
 				recursionTracker,
@@ -195,7 +195,7 @@ export default class MemberExpression extends NodeBase implements DeoptimizableE
 			return UNKNOWN_EXPRESSION;
 		}
 		this.expressionsToBeDeoptimized.push(origin);
-		if (path.length <= MAX_PATH_DEPTH) {
+		if (path.length < MAX_PATH_DEPTH) {
 			return this.object.getReturnExpressionWhenCalledAtPath(
 				[this.getPropertyKey(), ...path],
 				callOptions,
@@ -232,7 +232,7 @@ export default class MemberExpression extends NodeBase implements DeoptimizableE
 		if (this.replacement) {
 			return true;
 		}
-		if (path.length <= MAX_PATH_DEPTH) {
+		if (path.length < MAX_PATH_DEPTH) {
 			return this.object.hasEffectsWhenAccessedAtPath([this.getPropertyKey(), ...path], context);
 		}
 		return true;
@@ -245,7 +245,7 @@ export default class MemberExpression extends NodeBase implements DeoptimizableE
 		if (this.replacement) {
 			return true;
 		}
-		if (path.length <= MAX_PATH_DEPTH) {
+		if (path.length < MAX_PATH_DEPTH) {
 			return this.object.hasEffectsWhenAssignedAtPath([this.getPropertyKey(), ...path], context);
 		}
 		return true;
@@ -262,7 +262,7 @@ export default class MemberExpression extends NodeBase implements DeoptimizableE
 		if (this.replacement) {
 			return true;
 		}
-		if (path.length <= MAX_PATH_DEPTH) {
+		if (path.length < MAX_PATH_DEPTH) {
 			return this.object.hasEffectsWhenCalledAtPath(
 				[this.getPropertyKey(), ...path],
 				callOptions,

diff --git a/test/form/samples/deep-properties-access/_config.js b/test/form/samples/deep-properties-access/_config.js
@@ -0,0 +1,3 @@
+module.exports = {
+	description: 'handles deeply nested property accesses'
+};
diff --git a/test/form/samples/deep-properties-access/_expected.js b/test/form/samples/deep-properties-access/_expected.js
@@ -0,0 +1,2 @@
+var obj = { obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {}}}}}}}}}}};
+console.log(obj.obj.obj.obj.obj.obj.obj.obj.obj.foo);
diff --git a/test/form/samples/deep-properties-access/main.js b/test/form/samples/deep-properties-access/main.js
@@ -0,0 +1,2 @@
+var obj = { obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {}}}}}}}}}}};
+console.log(obj.obj.obj.obj.obj.obj.obj.obj.obj.foo);
diff --git a/test/form/samples/deep-properties/_config.js b/test/form/samples/deep-properties/_config.js
@@ -0,0 +1,6 @@
+module.exports = {
+	description: 'handles deeply nested properties',
+	options: {
+		treeshake: { propertyReadSideEffects: false }
+	}
+};
diff --git a/test/form/samples/deep-properties/_expected.js b/test/form/samples/deep-properties/_expected.js
@@ -0,0 +1,11 @@
+var obj1 = obj1;
+console.log(obj1.foo());
+
+var obj2 = { obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {}}}}}}}}}}};
+obj2.obj.obj.obj.obj.obj.obj.obj.foo();
+
+var obj3 = { obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {}}}}}}}}}}};
+if (obj3.obj.obj.obj.obj.obj.obj.obj.obj.foo) console.log('nested');
+
+var obj4 = { obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {}}}}}}}}}}};
+obj4.obj.obj.obj.obj.obj.obj.obj.foo = 'nested';
diff --git a/test/form/samples/deep-properties/main.js b/test/form/samples/deep-properties/main.js
@@ -0,0 +1,11 @@
+var obj1 = obj1;
+console.log(obj1.foo());
+
+var obj2 = { obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {}}}}}}}}}}};
+obj2.obj.obj.obj.obj.obj.obj.obj.foo();
+
+var obj3 = { obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {}}}}}}}}}}};
+if (obj3.obj.obj.obj.obj.obj.obj.obj.obj.foo) console.log('nested');
+
+var obj4 = { obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {obj: {}}}}}}}}}}};
+obj4.obj.obj.obj.obj.obj.obj.obj.foo = 'nested';
diff --git a/test/form/samples/recursive-property-call/_config.js b/test/form/samples/recursive-property-call/_config.js
diff --git a/test/form/samples/recursive-property-call/_expected.js b/test/form/samples/recursive-property-call/_expected.js
diff --git a/test/form/samples/recursive-property-call/main.js b/test/form/samples/recursive-property-call/main.js